fix bug in logic for exhaustIfMultipleContinuing overvote rule #610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moldover
reviewed
Aug 11, 2022
| @@ -796,9 +796,9 @@ private OvervoteDecision getOvervoteDecision(Set<String> candidateSet) { | |||
| if (continuingCandidate != null) { // at least two continuing | |||
| decision = OvervoteDecision.EXHAUST; | |||
| break; | |||
| } else { | |||
| continuingCandidate = candidate; | |||
|
OK, test added. |
|
same ask here... get rid of the test_set prefix |
moldover
approved these changes
Aug 17, 2022
|
Will do. Please accept the PRs preemptively so I can merge them as soon as I make these trivial updates (which might be at a weird time late tonight). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fun one. It definitely calls for a new test. Just waiting for guidance on the best way to do that.
Fixes #554.