Fail gracefully when there is no precinct information

src/main/java/network/brightspots/rcv/ResultsWriter.java

@@ -274,7 +274,12 @@ void generatePrecinctSummaryFiles(
       String precinctFileString = getPrecinctFileString(precinct, filenames);
       String outputPath =
           getOutputFilePathFromInstance(String.format("%s_precinct_summary", precinctFileString));
-      int numBallots = numBallotsByPrecinct.get(precinct);
+      Integer numBallotsObj = numBallotsByPrecinct.get(precinct);
+      if (numBallotsObj == null) {
+        Logger.warning("No ballots found in precinct \"%s\"", precinct, numBallotsByPrecinct);
+        numBallotsObj = 0;
+      }
+      int numBallots = numBallotsObj;
       generateSummarySpreadsheet(roundTallies, numBallots, precinct, outputPath);
       generateSummaryJson(roundTallies, precinctTallyTransfers.get(precinct), precinct, outputPath);
     }

src/main/java/network/brightspots/rcv/Tabulator.java

@@ -78,7 +78,8 @@ class Tabulator {
   // tracks required winning threshold
   private BigDecimal winningThreshold;
 
-  Tabulator(List<CastVoteRecord> castVoteRecords, ContestConfig config) {
+  Tabulator(List<CastVoteRecord> castVoteRecords, ContestConfig config)
+      throws TabulationAbortedException {
     this.castVoteRecords = castVoteRecords;
     this.candidateNames = config.getCandidateNames();
     this.config = config;
@@ -91,6 +92,11 @@ class Tabulator {
     }
 
     if (config.isTabulateByPrecinctEnabled()) {
+      if (precinctIds.size() == 0) {
+        Logger.severe("\"Tabulate by Precinct\" enabled, but CVRs don't list precincts.");
+        throw new TabulationAbortedException(false);
+      }
+
       initPrecinctRoundTallies();
     }
   }
@@ -841,7 +847,8 @@ private OvervoteDecision getOvervoteDecision(CandidatesAtRanking candidates) {
   //  logs the results to audit log
   //  update tallyTransfers counts
   private void recordSelectionForCastVoteRecord(
-      CastVoteRecord cvr, int currentRound, String selectedCandidate, String outcomeDescription) {
+      CastVoteRecord cvr, int currentRound,
+      String selectedCandidate, String outcomeDescription) throws TabulationAbortedException {
     // update transfer counts (unless there's no value to transfer, which can happen if someone
     // wins with a tally that exactly matches the winning threshold)
     if (cvr.getFractionalTransferValue().signum() == 1) {
@@ -851,13 +858,19 @@ private void recordSelectionForCastVoteRecord(
           selectedCandidate,
           cvr.getFractionalTransferValue());
       if (config.isTabulateByPrecinctEnabled()) {
-        precinctTallyTransfers
-            .get(cvr.getPrecinct())
-            .addTransfer(
-                currentRound,
-                cvr.getCurrentRecipientOfVote(),
-                selectedCandidate,
-                cvr.getFractionalTransferValue());
+        String precinctId = cvr.getPrecinct();
+        TallyTransfers precinctTallyTransfer = precinctTallyTransfers.get(precinctId);
+        if (precinctTallyTransfer == null) {
+          Logger.severe(
+              "Precinct \"%s\" is not among the %d known precincts.",
+              precinctId, precinctIds.size());
+          throw new TabulationAbortedException(false);
+        }
+        precinctTallyTransfer.addTransfer(
+            currentRound,
+            cvr.getCurrentRecipientOfVote(),
+            selectedCandidate,
+            cvr.getFractionalTransferValue());
       }
     }
 
@@ -879,7 +892,8 @@ private void recordSelectionForCastVoteRecord(
   //  - exhaust cvrs if they should be exhausted for various reasons
   //  - assign cvrs to continuing candidates if they have been transferred or in the initial count
   // returns a map of candidate ID to vote tallies for this round
-  private Map<String, BigDecimal> computeTalliesForRound(int currentRound) {
+  private Map<String, BigDecimal> computeTalliesForRound(int currentRound)
+          throws TabulationAbortedException {
     Map<String, BigDecimal> roundTally = getNewTally();
     Map<String, Map<String, BigDecimal>> roundTallyByPrecinct = new HashMap<>();
     if (config.isTabulateByPrecinctEnabled()) {

src/test/java/network/brightspots/rcv/TabulatorTests.java

@@ -598,4 +598,11 @@ void genericCsvTest() {
   void noOneMeetsMinimumTest() {
     runTabulationTest("no_one_meets_minimum", TabulationAbortedException.class.toString());
   }
+
+  @Test
+  @DisplayName("gracefully fail when tabulate-by-precinct option set without any precincts in CVR")
+  void tabulateByPrecinctWithoutPrecincts() {
+    runTabulationTest("tabulate_by_precinct_without_precincts",
+        TabulationAbortedException.class.toString());
+  }
 }

src/test/resources/network/brightspots/rcv/test_data/tabulate_by_precinct_without_precincts/tabulate_by_precinct_without_precincts_config.json

@@ -0,0 +1,85 @@
+{
+  "tabulatorVersion" : "TEST",
+  "outputSettings" : {
+    "contestName" : "Wyoming Dominion test",
+    "outputDirectory" : "output",
+    "contestDate" : "2020-07-19",
+    "contestJurisdiction" : "Wyoming",
+    "contestOffice" : "Democratic Primary",
+    "tabulateByPrecinct" : true,
+    "generateCdfJson" : false
+  },
+  "cvrFileSources" : [ {
+    "filePath" : "tabulate_by_precinct_without_precincts_input_data",
+    "contestId" : "1",
+    "idColumnIndex" : "",
+    "precinctColumnIndex" : "",
+    "overvoteDelimiter" : "",
+    "provider" : "dominion",
+    "overvoteLabel" : "",
+    "undervoteLabel" : "",
+    "undeclaredWriteInLabel" : "12",
+    "treatBlankAsUndeclaredWriteIn" : false
+  } ],
+  "candidates" : [ {
+    "name" : "Joseph R. Biden",
+    "excluded" : false,
+    "aliases" : [ ],
+    "code" : "1"
+  }, {
+    "name" : "Tom Steyer",
+    "excluded" : false,
+    "aliases" : [ ],
+    "code" : "3"
+  }, {
+    "name" : "Bernie Sanders",
+    "excluded" : false,
+    "aliases" : [ ],
+    "code" : "4"
+  }, {
+    "name" : "Amy Klobuchar",
+    "excluded" : false,
+    "aliases" : [ ],
+    "code" : "5"
+  }, {
+    "name" : "Tulsi Gabbard",
+    "excluded" : false,
+    "aliases" : [ ],
+    "code" : "7"
+  }, {
+    "name" : "Elizabeth Warren",
+    "excluded" : false,
+    "aliases" : [ ],
+    "code" : "8"
+  }, {
+    "name" : "Michael R. Bloomberg",
+    "excluded" : false,
+    "aliases" : [ ],
+    "code" : "9"
+  }, {
+    "name" : "Pete Buttigieg",
+    "excluded" : false,
+    "aliases" : [ ],
+    "code" : "11"
+  } ],
+  "rules" : {
+    "tiebreakMode" : "useCandidateOrder",
+    "overvoteRule" : "exhaustImmediately",
+    "winnerElectionMode" : "singleWinnerMajority",
+    "randomSeed" : "",
+    "numberOfWinners" : "1",
+    "multiSeatBottomsUpPercentageThreshold" : "",
+    "decimalPlacesForVoteArithmetic" : "4",
+    "minimumVoteThreshold" : "0",
+    "maxSkippedRanksAllowed" : "1",
+    "maxRankingsAllowed" : "8",
+    "nonIntegerWinningThreshold" : false,
+    "hareQuota" : false,
+    "batchElimination" : true,
+    "continueUntilTwoCandidatesRemain" : false,
+    "stopTabulationEarlyAfterRound" : "",
+    "exhaustOnDuplicateCandidate" : false,
+    "rulesDescription" : "Wyoming Rules",
+    "treatBlankAsUndeclaredWriteIn" : false
+  }
+}

src/test/resources/network/brightspots/rcv/test_data/tabulate_by_precinct_without_precincts/tabulate_by_precinct_without_precincts_input_data/BallotTypeContestManifest.json

@@ -0,0 +1,9 @@
+{
+  "Version": "5.10.11.24",
+  "List": [
+    {
+      "BallotTypeId": 1,
+      "ContestId": 1
+    }
+  ]
+}

src/test/resources/network/brightspots/rcv/test_data/tabulate_by_precinct_without_precincts/tabulate_by_precinct_without_precincts_input_data/BallotTypeManifest.json

@@ -0,0 +1,10 @@
+{
+  "Version": "5.10.11.24",
+  "List": [
+    {
+      "Description": "Ballot 1 - Type 1",
+      "Id": 1,
+      "ExternalId": ""
+    }
+  ]
+}

src/test/resources/network/brightspots/rcv/test_data/tabulate_by_precinct_without_precincts/tabulate_by_precinct_without_precincts_input_data/CandidateManifest.json

@@ -0,0 +1,68 @@
+{
+  "Version": "5.10.11.24",
+  "List": [
+    {
+      "Description": "Tulsi Gabbard",
+      "Id": 7,
+      "ExternalId": "",
+      "ContestId": 1,
+      "Type": "Regular"
+    },
+    {
+      "Description": "Pete Buttigieg",
+      "Id": 11,
+      "ExternalId": "",
+      "ContestId": 1,
+      "Type": "Regular"
+    },
+    {
+      "Description": "Joseph R. Biden",
+      "Id": 1,
+      "ExternalId": "",
+      "ContestId": 1,
+      "Type": "Regular"
+    },
+    {
+      "Description": "Michael R. Bloomberg",
+      "Id": 9,
+      "ExternalId": "",
+      "ContestId": 1,
+      "Type": "Regular"
+    },
+    {
+      "Description": "Elizabeth Warren",
+      "Id": 8,
+      "ExternalId": "",
+      "ContestId": 1,
+      "Type": "Regular"
+    },
+    {
+      "Description": "Amy Klobuchar",
+      "Id": 5,
+      "ExternalId": "",
+      "ContestId": 1,
+      "Type": "Regular"
+    },
+    {
+      "Description": "Bernie Sanders",
+      "Id": 4,
+      "ExternalId": "",
+      "ContestId": 1,
+      "Type": "Regular"
+    },
+    {
+      "Description": "Tom Steyer",
+      "Id": 3,
+      "ExternalId": "",
+      "ContestId": 1,
+      "Type": "Regular"
+    },
+    {
+      "Description": "(undeclared)",
+      "Id": 12,
+      "ExternalId": "",
+      "ContestId": 1,
+      "Type": "Regular"
+    }
+  ]
+}

src/test/resources/network/brightspots/rcv/test_data/tabulate_by_precinct_without_precincts/tabulate_by_precinct_without_precincts_input_data/Configuration.json

@@ -0,0 +1,15 @@
+{
+  "IncludeTabulatorFilter": false,
+  "TabulatorFilterValue": 0,
+  "IncludeResultContainerFilter": false,
+  "ResultContainerFilterValue": 0,
+  "IncludePrecinctPortionFilter": false,
+  "PrecinctPortionFilterValue": 0,
+  "IncludeBallotTypeFilter": false,
+  "BallotTypeFilterValue": 0,
+  "IncludeContestFilter": false,
+  "ContestFilterValue": 0,
+  "SplitFilesPerBatch": false,
+  "IncludeOnlyPublishedResultContainers": true,
+  "UseTabulatorFormat": false
+}

src/test/resources/network/brightspots/rcv/test_data/tabulate_by_precinct_without_precincts/tabulate_by_precinct_without_precincts_input_data/ContestManifest.json

@@ -0,0 +1,13 @@
+{
+  "Version": "5.10.11.24",
+  "List": [
+    {
+      "Description": "PRESIDENT OF THE UNITED STATES",
+      "Id": 1,
+      "ExternalId": "",
+      "DistrictId": 2,
+      "VoteFor": 1,
+      "NumOfRanks": 5
+    }
+  ]
+}

src/test/resources/network/brightspots/rcv/test_data/tabulate_by_precinct_without_precincts/tabulate_by_precinct_without_precincts_input_data/CountingGroupManifest.json

@@ -0,0 +1,15 @@
+{
+  "Version": "5.10.11.24",
+  "List": [
+    {
+      "Description": "Election Day",
+      "Id": 1,
+      "ExternalId": ""
+    },
+    {
+      "Description": "Vote by Mail",
+      "Id": 2,
+      "ExternalId": ""
+    }
+  ]
+}