Allow bouncycastle to build on non-Oracle JDKs #769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HEdingfield
approved these changes
Nov 10, 2023
| @@ -106,7 +106,7 @@ jlink { | |||
| imageDir = file(JLINK_DIR) | |||
| imageZip = file(JLINK_DIR + ".zip") | |||
| addOptions '--add-modules', MODULES_TO_ADD, '--strip-debug', '--compress', '2', | |||
| '--no-header-files', '--no-man-pages' | |||
| '--no-header-files', '--no-man-pages', '--ignore-signing-information' | |||
There was a problem hiding this comment.
Is there a downside / danger to adding this?
If not, should we merge into 1.4.0 as well?
If so, we should flag this PR in #767 as another thing we'd need to eventually get into 1.4.0.
There was a problem hiding this comment.
I will definitely flag this in #767 to address before merging to 1.4.0
There was a problem hiding this comment.
I think we do need to. I created a draft PR for discussion here: #770
This was referenced Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: https://stackoverflow.com/questions/50597926/signed-modular-jar-with-crypto-provider-cannot-be-linked-into-run-time-image/68295740#68295740 for the error we were getting on openjdk