Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UnwrapWith not setting base step value #2691

Merged
merged 3 commits into from
Jun 11, 2023

Conversation

KieranBond
Copy link
Contributor

Update UnwrapWith to set base Step property

Resolves #2616

@CLAassistant
Copy link

CLAassistant commented Jun 11, 2023

CLA assistant check
All committers have signed the CLA.

@KieranBond
Copy link
Contributor Author

Thanks for your approval @iancooper. Looks like the two failing checks are for reasons unassociated with the changes.

Can we skip them? Or do we need to retry the actions?

Copy link
Member

@preardon preardon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I can merge this in if you would like

@KieranBond
Copy link
Contributor Author

If you're happy, I'm happy 😅

@preardon preardon merged commit bc24503 into BrighterCommand:master Jun 11, 2023
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]Missing base step value in UnwrapWithAttribute
4 participants