Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix capitalization in immutability diagnostic #675

Closed
j3parker opened this issue Dec 11, 2020 · 0 comments · Fixed by #676
Closed

Fix capitalization in immutability diagnostic #675

j3parker opened this issue Dec 11, 2020 · 0 comments · Fixed by #676
Labels
good first issue projects/undiff

Comments

@j3parker
Copy link
Member

Related to #650

We emit diagnostics like:

The Class Foo is missing the [Immutable] attribute, so it isn't safe to be held by an immutable type

Class comes from a TypeKind enum value... we should lower case that because it looks weird.
TimothyJCowen added a commit that referenced this issue Dec 11, 2020
@TimothyJCowen
Fix capitalization in immutability diagnostic #675
5453915 
- Added ".toString().toLower()" to force lowercase of "class", "interface" and "structure"
- Adjusted tests to take new capitalization into account

Closes: #675
@TimothyJCowen TimothyJCowen mentioned this issue Dec 11, 2020
Merged
TimothyJCowen added a commit that referenced this issue Dec 11, 2020
@TimothyJCowen
Fix capitalization in immutability diagnostic #675 (#676)
39ea7ad 
- Added ".toString().toLower()" to force lowercase of "class", "interface" and "structure"
- Adjusted tests to take new capitalization into account

Closes: #675

Co-authored-by: Timothy J Cowen <tj.cowen@d2l.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue projects/undiff
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix capitalization in immutability diagnostic #675 Brightspace/D2L.CodeStyle
1 participant
@j3parker