refact: return detailed error messages for WebApi integration #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omsmith
commented
Dec 4, 2018
| error: exception.Error.ToString(), | ||
| errorDescription: exception.ErrorDescription | ||
| ); | ||
| string authenticateHeader = $"Bearer error=\"{ responseContent.Error }\", error_description=\"{ responseContent.ErrorDescription }\""; |
| @@ -57,5 +94,12 @@ public abstract class OAuth2AuthorizeAttribute : AuthorizeAttribute { | |||
|
|
|||
| protected abstract bool IsAuthorizedInternal( HttpActionContext actionContext ); | |||
|
|
|||
| private static void HandleNoAuth( HttpActionContext actionContext ) { | |||
There was a problem hiding this comment.
TODO: verify this occurs and it's not just a different code path doing No-Auth 401s
| @@ -24,7 +24,7 @@ await TestUtilities.RunBasicAuthTest( "/authorization/unspecifiedprincipaltype", | |||
|
|
|||
|
|
|||
| [Test] | |||
| public async Task Basic_NoAuthentication_403() { | |||
| public async Task Basic_NoAuthentication_401() { | |||
| await TestUtilities | ||
| .RunBasicAuthTest( "/authorization/imp", jwt, HttpStatusCode.Forbidden ) | ||
| var response = await TestUtilities | ||
| .RunBasicAuthTest<OAuth2ErrorResponse>( "/authorization/imp", jwt, HttpStatusCode.Unauthorized ) |
There was a problem hiding this comment.
I changed these cause of the RFC suggestion, and I didn't think it super terribly mattered.
invalid_token
The access token provided is expired, revoked, malformed, or
invalid for other reasons. The resource SHOULD respond with
the HTTP 401 (Unauthorized) status code. The client MAY
request a new access token and retry the protected resource
request.
omsmith
force-pushed
the
webapi-detailed-errors
branch
from
900cc5c
to
1a9979f
Compare
omsmith
force-pushed
the
webapi-detailed-errors
branch
from
1a9979f
to
2bccfda
Compare
j3parker
previously requested changes
Apr 1, 2020
|
We're going to deprecate the WebAPI library because it is incompatible with ASP.NET Core. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #40