Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add typescript typings #24

Merged
merged 1 commit into from Jan 25, 2019
Merged

add typescript typings #24

merged 1 commit into from Jan 25, 2019

Conversation

uwinkelvos
Copy link

Hi!

For the typescript users of us those would be really helpfull and they are also used for auto api docs by some IDEs.

Cheers Ulf

@coveralls
Copy link

coveralls commented Dec 21, 2018

Coverage Status

Coverage remained the same at 99.065% when pulling a44c45a on uwinkelvos:master into 6b17bbe on Brightspace:master.

@omsmith
Copy link
Contributor

omsmith commented Dec 21, 2018

Thanks @uwinkelvos. I'm not terribly aware of the specifics of type definition files. Could it possibly live at src/ecdsa-sig-formatter.d.ts instead?

@uwinkelvos
Copy link
Author

Thanks @uwinkelvos. I'm not terribly aware of the specifics of type definition files. Could it possibly live at src/ecdsa-sig-formatter.d.ts instead?

Actually: yes! :)

@omsmith omsmith merged commit a44c45a into Brightspace:master Jan 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants