Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we be exiting the process from a library? #2

Closed
omsmith opened this issue Sep 4, 2015 · 3 comments
Closed

Should we be exiting the process from a library? #2

omsmith opened this issue Sep 4, 2015 · 3 comments
Labels

Comments

@omsmith
Copy link
Contributor

omsmith commented Sep 4, 2015

No description provided.

@ryantmer
Copy link
Collaborator

ryantmer commented Sep 8, 2015

I feel that in the general case no, but here I'd say yes, since it's not public and/or being used in a bunch of projects, and exiting is an expected (and preferred) behaviour. Short of exiting, logging seems like the only other simple option, and that is easily overlooked, and won't really have an effect on deployments.

Idk, no groundbreaking thoughts, but it seems rational enough to me to exit, in this particular case.

@awikkerink
Copy link

Maybe throw an exception? The envOr should be called directly inside modules, so node should exit because of the uncaught exceptions.

@ryantmer
Copy link
Collaborator

@awikkerink good point. Can even just be a standard Error with the same message that's currently being log.error'd.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants