Polymer 3 Conversion #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
margaree
requested review from
njostonehouse,
dlockhart,
dbatiste and
svanherk
margaree
requested review from
alogan519,
awikkerink and
mdgbayly
as code owners
dlockhart
reviewed
Dec 5, 2018
| "globals": { | ||
| "fastdom": false, | ||
| "Promise": false | ||
| }, | ||
| "env": { | ||
| "es6": true |
There was a problem hiding this comment.
I'm surprised you needed this... I don't think we've needed it elsewhere.
There was a problem hiding this comment.
Mhmm, I'm a bit confused about this as well.
There was a problem hiding this comment.
So it looks like according to elint docs (https://eslint.org/docs/user-guide/configuring#specifying-parser-options) and issues (eslint/eslint#5674, eslint/eslint#7984) this is currently necessary for what we're seeing this for - Map and Set. From a bit of searching, it doesn't look like we have converted anything else that uses them yet.
There was a problem hiding this comment.
Gotcha, cool, thanks for looking into it!
dlockhart
approved these changes
Dec 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patches related to:
'Map' is not defined,no-undef(added es6 to .eslintrc.json for this)'oldEntity' is defined but never used,no-unused-varsUnnecessary escape character: \(,no-useless-escape