Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to serve CSS files to the synchronous calls of LoadBy File/N... #7

Merged
merged 5 commits into from
Nov 24, 2014
Merged

Add ability to serve CSS files to the synchronous calls of LoadBy File/N... #7

merged 5 commits into from
Nov 24, 2014

Conversation

njostonehouse
Copy link
Contributor

...ame/Definition.

@njostonehouse
Copy link
Contributor Author

@dlockhart Have a look, this should occur for asynch too.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 339379b on nstonehouse/vui-baseline/synchronous-css into 91eeef1 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 7b5319b on nstonehouse/vui-baseline/synchronous-css into 91eeef1 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 7b5319b on nstonehouse/vui-baseline/synchronous-css into 91eeef1 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling f2ab425 on nstonehouse/vui-baseline/synchronous-css into 91eeef1 on master.

dlockhart
dlockhart reviewed Nov 24, 2014
View reviewed changes
lib/loadByFileSync.js
@@ -16,19 +16,38 @@ module.exports = function( packagePath ) {
{ 'noblanks' : true }
);

var filePaths = { };
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion to save a couple lines down below:
var filePaths = { JS: [], CSS: [] };

@dlockhart
Copy link
Member

@njostonehouse looks good!

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling f4ea69d on nstonehouse/vui-baseline/synchronous-css into 91eeef1 on master.

njostonehouse added a commit that referenced this pull request Nov 24, 2014
@njostonehouse
Merge pull request #7 from Brightspace/nstonehouse/vui-baseline/synch…
82d45c2 
…ronous-css

Add ability to serve CSS files to the synchronous calls of LoadBy File/N...
@njostonehouse njostonehouse merged commit 82d45c2 into master Nov 24, 2014
@njostonehouse njostonehouse deleted the nstonehouse/vui-baseline/synchronous-css branch November 24, 2014 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@njostonehouse @coveralls @dlockhart