Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow no update of option checked state #42

Closed
wants to merge 3 commits into from
Closed

allow no update of option checked state #42

wants to merge 3 commits into from

Conversation

mdulat
Copy link
Contributor

@mdulat mdulat commented Feb 29, 2020

To allow d2l-filter-dropdown-option to not update the checked state automatically, instead allowing consumer to set selected explicitly. This allows consumer components to not uncheck a menu item when it is clicked multiple times (use case is when one item must always be ckecked).

@dbatiste
Copy link
Contributor

dbatiste commented Mar 2, 2020

This seems like it could be confusing to screen reader users. It is kinda like it's behaving as disabled. If the menu item behavior support disabled however, that could also be confusing to them, because for the use case mentioned, the disabled state would be changing as they select/unselect items. 🤔

@mdulat
Copy link
Contributor Author

mdulat commented Mar 2, 2020

This seems like it could be confusing to screen reader users. It is kinda like it's behaving as disabled. If the menu item behavior support disabled however, that could also be confusing to them, because for the use case mentioned, the disabled state would be changing as they select/unselect items. 🤔

Ah, you're right, I think we want radio items in our case here instead of checkboxes. We're replacing the dropdowns in the question library import page (see https://qa2020420950g.bspc.com/d2l/lms/qc/main_frame.d2l?ctid=1&ti=51000&ou=123117, select Import --> Browse Existing Questions). Sort is replaced with d2l-sort-by-dropdown, Filter with d2l-filter-dropdown, and Source is kind of a combination of the two, because it should be a menu with radio buttons, but it also needs tabs, so we used d2l-filter-dropdown. Hmmm.

@mdulat mdulat closed this Mar 2, 2020
@mdulat
Copy link
Contributor Author

mdulat commented Mar 2, 2020

Turns out we can use d2l-sort-by-dropdown-option within d2l-filter-dropdown, does exactly what we want.

@svanherk svanherk deleted the no_update branch March 6, 2020 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants