Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom-elements.json #53

Merged
merged 1 commit into from
Jun 25, 2020
Merged

Add custom-elements.json #53

merged 1 commit into from
Jun 25, 2020

Conversation

margaree
Copy link
Contributor

This PR adds web components analyzer to generate custom-elements.json and adds more jsdoc comments throughout the components.
I did add custom-elements.json into source control since this isn't published to npm so I couldn't do what was done in core. It would be great to have this more automated so if anyone has suggestions there, that would be awesome.

@svanherk
Copy link
Contributor

Would it be crazy to add this to the frau-ci auto-bumping? During the [skip ci] step that ups the version, could it look for a certain npm command and/or the existence of the file, and run it and commit the new file?

@svanherk
Copy link
Contributor

svanherk commented Jun 24, 2020

Or if we're moving away from frau-ci for UI and Labs, can we start moving everyone to the semantic release stuff and work it into that workflow? Or does that only make sense for components publishing to npm?

@margaree
Copy link
Contributor Author

So I think many labs components (at least all the ones I looked at quickly) are publishing to npm so I think for this custom-elements.json, adding the workflow used in core into them would make the most sense rather than adding it into frau-ci.

@margaree margaree merged commit bf957e9 into master Jun 25, 2020
@margaree margaree deleted the add-analyzer branch June 25, 2020 12:59
@dlockhart
Copy link
Contributor

Let's not add frau-ci to anything new -- semantic-release would work well here as it can do GitHub and/or NPM releases. In the configuration for updating package.json, you can include other files that should be committed, so we could just add custom-elements.json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants