Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚧 add AVCNN_Model, KMax_CNN_Model & related customized layers #116

Merged
merged 7 commits into from Jun 26, 2019

Conversation

alexwwang
Copy link
Collaborator

@alexwwang alexwwang commented Jun 25, 2019

4/6

classification.__init__.py would be updated when all models finished.

@BrikerMan
Copy link
Owner

@alexwwang Build failed, check it out.

@alexwwang
Copy link
Collaborator Author

alexwwang commented Jun 25, 2019 via email

@BrikerMan
Copy link
Owner

BrikerMan commented Jun 26, 2019

@alexwwang I think this might help with issues like

A002 "sorted" is used as an argument and thus shadows a python builtin, consider renaming the argument

Check it out, http://flake8.pycqa.org/en/3.1.1/user/ignoring-errors.html#in-line-ignoring-errors

@alexwwang
Copy link
Collaborator Author

thanks a lot.
let me have a try.

@alexwwang
Copy link
Collaborator Author

it's so awkward. 🤦‍♂️

@BrikerMan
Copy link
Owner

it's so awkward. 🤦‍♂️

Haha, that's ok, You could install flake8 and run before commit locally.

pip install flake8 flake8-builtins
flake8 kashgari

@alexwwang
Copy link
Collaborator Author

I'll do it right now!

@BrikerMan BrikerMan merged commit ded4141 into BrikerMan:tf.keras-version Jun 26, 2019
@alexwwang
Copy link
Collaborator Author

Done! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants