Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Google Inbox plugin #109

Closed
xarg opened this issue Mar 20, 2015 · 13 comments
Closed

Google Inbox plugin #109

xarg opened this issue Mar 20, 2015 · 13 comments
Assignees
@ghinda
Labels
webmail

Comments

@xarg
Copy link
Contributor

xarg commented Mar 20, 2015

By popular request make a Google Inbox plugin.
@xarg xarg added the webmail label Mar 20, 2015
@xarg xarg self-assigned this Mar 20, 2015
@xarg xarg assigned clay-reed-a and unassigned xarg Oct 15, 2015
@RomainLapeyre
Copy link
Contributor

+1

@RomainLapeyre
Copy link
Contributor

+1

@RomainLapeyre
Copy link
Contributor

Keyboard completion and CTRL+SPACE Work.

Need to add support variables + quick access button.

@RomainLapeyre
Copy link
Contributor

+1

4 similar comments
@RomainLapeyre
Copy link
Contributor

+1

@luisherranz
Copy link

+1

@xarg
Copy link
Contributor Author

xarg commented Sep 19, 2016

+1

@RomainLapeyre
Copy link
Contributor

+1

@RomainLapeyre
Copy link
Contributor

@xarg what do you think of asking a freelancer to do it?

@xarg
Copy link
Contributor Author

xarg commented Dec 21, 2016

@ghinda can you please have a look at what can we do here? There is really lots of demand for this.

@ghinda ghinda added in progress and removed ready labels Dec 22, 2016
@ghinda
Copy link
Member

ghinda commented Dec 22, 2016

Started work on the plugin for Google Inbox.

It's still very much wip. Will finish it up after the new year's.
Branch is ghinda--googleinbox-suport.

@ghinda ghinda mentioned this issue Jan 10, 2017
Merged
@ghinda ghinda self-assigned this Jan 10, 2017
@xarg xarg closed this as completed Jan 10, 2017
@xarg xarg removed the in progress label Jan 10, 2017
@xarg
Copy link
Contributor Author

xarg commented Feb 24, 2017

@ghinda seems there are some issues with Inbox still. For example the text sometimes goes outside of the edit area and stays there. See the gif below:
screenflow

To reproduce this, I deleted all the text and then used the dialog. Seems like it loses focus from the editor and goes to the element on top of it.

Unrelated: Can we also add the little g button in the compose area?

@xarg xarg reopened this Feb 24, 2017
ghinda added a commit that referenced this issue Feb 27, 2017
@ghinda
Fix issues with inserting template before the editor, in Google Inbox…
7a02291 
…, when the editor is empty.

#109 (comment)
@ghinda ghinda mentioned this issue Feb 27, 2017
Merged
ghinda added a commit that referenced this issue Mar 27, 2017
@ghinda
Fix issues with inserting template before the editor, in Google Inbox…
64847c8 
…, when the editor is empty.

#109 (comment)
xarg pushed a commit that referenced this issue Mar 27, 2017
@ghinda @xarg
Google Inbox hotfix for inserting templates when editor is empty (#246)
514b85f 
* Fix issues with inserting template before the editor, in Google Inbox, when the editor is empty.
#109 (comment)

* Implement a whitelist for the quick-action button, and enable it for google inbox.
Fix broken quick-action button positioning, caused by trying to clone the boundingClientRect dimensions.
The problem wasn't visibile because Gmail uses custom positioning.

* In Google Inbox, the BCC field was filled with the CC value.

* `from` stopped working in the Google Inbox plugin.
Google Inbox changed the markup classes, so the account info node was not found.
Change the way we get `from` data in the Inbox plugin, to prevent changed classes from affecting it.
@xarg xarg closed this as completed Mar 27, 2017
@xarg xarg removed the in progress label Mar 27, 2017
@xarg
Copy link
Contributor Author

xarg commented Mar 27, 2017

Fixed in version 5.6.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ghinda ghinda

Labels
webmail
Milestone
No milestone
Development

No branches or pull requests
5 participants
@xarg @ghinda @luisherranz @RomainLapeyre @clay-reed-a