Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Universal attachment support #505

Merged
merged 20 commits into from
Jul 7, 2023
Merged

Universal attachment support #505

merged 20 commits into from
Jul 7, 2023

Conversation

ghinda
Copy link
Member

@ghinda ghinda commented Jul 7, 2023

Changes:

  • Add support for attachments on all websites. Fixes Support attachments in Outlook #400
  • On websites without rich text support, attachments use link formatting (file-name [file-url]).
  • Tweak visual style for attachments, and use our own hosted file-type icons (instead of the previous Gmail-specific ones).
  • Fix issues with not updating templates when switching teams.

ghinda added 20 commits June 28, 2023 11:35
@ghinda
Upgrade outdated dependencies.
e3497b2
@ghinda
Initial work on universal attachments.
2eb7345
@ghinda
Global styles for the new universal attachments.
becb1f3
@ghinda
Use table layout and img tags for the attachments.
0847156
@ghinda
Fix issues with gmail stripping out the table inline styles.
5879edf
@ghinda
Use background image for attachment icons.
5082282 
Avoid the image box with border when images are not displayed in gmail.
@ghinda
Remove line breaks between attachments.
65ccc76 
Switch handlers to mouseup, instead of mousedown.
@ghinda
Fix text overflow for attachments with long names.
412585e
@ghinda
Switch back to mousedown to prevent further interaction with the atta…
cd6d95d 
…chments (eg. drag to edit).
@ghinda
Attachment support for linkedin and outlook.
27ea423
@ghinda
Add attachment support in all remaining plugins.
ed64875
@ghinda
Add a line-break after the last attachment, to prevent the current fr…
fd2acc3 
…om getting in line with it.
@ghinda
Remove old gmail attachment functionality.
96435aa
@ghinda
Upgrade outdated dependencies.
598e85b
@ghinda
Bump version.
9c65f04
@ghinda
Move static assets to static.briskine.com.
4ddd158
@ghinda
Fix slate e2e test.
ba19ec0
@ghinda
Upgrade eslint.
21574a2
@ghinda
Update tags and templates when we switch to a different customer.
5313520
@ghinda
Bump safari version.
6308339
@ghinda ghinda self-assigned this Jul 7, 2023
@ghinda ghinda merged commit 4b9a2fe into master Jul 7, 2023
1 check passed
@ghinda ghinda deleted the ghinda--attachments branch July 7, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ghinda ghinda

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support attachments in Outlook
1 participant
@ghinda