Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements for WhatsApp Web #510

Merged
merged 6 commits into from
Aug 24, 2023
Merged

Improvements for WhatsApp Web #510

merged 6 commits into from
Aug 24, 2023

Conversation

ghinda
Copy link
Member

@ghinda ghinda commented Aug 24, 2023

Changes:

  • Improve removing template shortcuts on WhatsApp Web.
  • Speed up the initial template insert, but wait after removing the template shortcut, for slate support.

…ugin.

Fix issues with the latest whatsapp web version.
Add another test for inserting a template after preceeding text in lexical.
Do not dispatch the deleteWordBackward event anymore, since the insertion will replace selected text.
Improves shortcut insertion on WhatsApp Web.
…gin.

Slate needs it to notice the new selection and later remove it with insertReplacementText.
Remove the initial setTimeout initially used for slate.
@ghinda ghinda self-assigned this Aug 24, 2023
@ghinda ghinda merged commit ad4c0c2 into master Aug 24, 2023
1 check passed
@ghinda ghinda deleted the ghinda--whatsapp2 branch August 24, 2023 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant