New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inserting single-link template in ProseMirror #512

Merged

ghinda merged 4 commits into master from ghinda--hubspot-link

Sep 12, 2023

Member

ghinda commented Sep 12, 2023 •

edited

Changes:

Fix inserting a template with a single anchor tag on ProseMirror (used by HubSpot).
ProseMirror strips out the anchor tag under certain conditions, so we need to use a workaround to keep it.
Add a unit test for the specific bug.

ghinda added 4 commits

September 5, 2023 09:45


          Upgrade outdated dependencies.

264fabd


          Add a mocha test replicating the issue with prosemirror removing anch…

5275f81

…ors, when they are the only content of the template.


          Add a workaround for the bug with prosemirror stripping out anchor tags,

6f4a1c3

when the template only has a container and the anchor.


          Bump version.

9fe8af7

ghinda self-assigned this

ghinda merged commit 5df677f into master

1 check passed

ghinda deleted the ghinda--hubspot-link branch

September 12, 2023 13:16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment