updated dockerfile to install necessary python3.9 #32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hey,
wanted to run this in a docker container with the provided Dockerfile but it didn't work due to wrong python-version being installed in the Dockerfile.
Running twitch-archiver in the container gave me:
Traceback (most recent call last): File "/usr/local/bin/twitch-archiver", line 5, in <module> from twitcharchiver.__init__ import main File "/usr/local/lib/python3.8/dist-packages/twitcharchiver/__init__.py", line 40, in <module> from twitcharchiver.channel import Channel File "/usr/local/lib/python3.8/dist-packages/twitcharchiver/channel.py", line 10, in <module> from twitcharchiver.api import Api File "/usr/local/lib/python3.8/dist-packages/twitcharchiver/api.py", line 9, in <module> from twitcharchiver.exceptions import ( File "/usr/local/lib/python3.8/dist-packages/twitcharchiver/exceptions.py", line 10, in <module> from twitcharchiver.utils import get_temp_dir File "/usr/local/lib/python3.8/dist-packages/twitcharchiver/utils.py", line 20, in <module> from twitcharchiver.twitch import Chapters File "/usr/local/lib/python3.8/dist-packages/twitcharchiver/twitch.py", line 82, in <module> class Chapters: File "/usr/local/lib/python3.8/dist-packages/twitcharchiver/twitch.py", line 88, in Chapters def __init__(self, moments: list[dict] = None): TypeError: 'type' object is not subscriptable
Affected Line:
def __init__(self, moments: list[dict] = None):
Description:
https://docs.python.org/3.9/whatsnew/3.9.html#type-hinting-generics-in-standard-collections
Change:
Installing python v3.9 instead of v3.8.10 (ubuntu default)