[BUG] Segmentation fault at the end of run

[kreczko]

At the moment it seems that there is a segmentation fault at the end of running the software.
This looks like a null pointer is being dereferenced in one of the destructors.

The problem can be reproduced by running test/TestBinnedVariableAnalyser.cpp which is part of the unit tests. It is only seen when running the executable itself (AnalysisSoftware_test) and not when executing make test.

Based on the involved classes the error is either located in HistogramManager or Binned_variable_analyser.

[kreczko]

The problem lies with

boost::shared_ptr<TFile> file(new TFile("TestROOT.root", "RECREATE"));

The TFile pointer is deleted before the shared_ptr gets its chance to delete it.

[kreczko]

However, once the TFile problem was fixed, a new one appeared.
This time it is in the destructor of TEfficiency.

[EmyrClement]

How was the problem fixed?

[kreczko]

By leaving out 'Close()' and letting the TFile destructor do the work.
I have the feeling I should change how we use Globals in order to fix the problem (e.g. make it a SingleTon).
I will try to introduce the new model as BAT::Setup sometime next week.