Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove position correction broke PV5.1 conversion #10

Closed
gdevenyi opened this issue Jun 5, 2020 · 7 comments
Closed

Remove position correction broke PV5.1 conversion #10

gdevenyi opened this issue Jun 5, 2020 · 7 comments

Comments

@gdevenyi
Copy link
Collaborator

gdevenyi commented Jun 5, 2020

Hi,

This commit
686036a

Broke the PV5.1 orientation. I now get my mouse-phatom converted backward.

@gdevenyi
Copy link
Collaborator Author

gdevenyi commented Jun 5, 2020

0.3.3rc0:
image

HEAD (0.3.3)
image

@gdevenyi
Copy link
Collaborator Author

gdevenyi commented Jun 5, 2020

Scans collected on PV6 seem to work properly.

@dvm-shlee
Copy link
Member

@gdevenyi Thank you for reporting!
Yeah, I forgot there was the reason that I've added the position correction.
Currently, I made a quick patch to correct the subject position on PV5.
Please let me know if this does not properly work.
(version 0.3.4b0, but does not update on PyPi yet)

Thank you!

@gdevenyi
Copy link
Collaborator Author

gdevenyi commented Jun 6, 2020

Things, commit has fixed things.

Can you please git tag all your rc releases so they're easier to test against? Thanks.

@gdevenyi gdevenyi closed this as completed Jun 6, 2020
@dvm-shlee
Copy link
Member

@gdevenyi That's a great suggestion,
Still learning the way working with GitHub.
Will tag including the all prerelease as well for the future.

Thanks!

@gdevenyi
Copy link
Collaborator Author

Hi, I need to reopen this and apologize. It seems that all of our data has been collected incorrectly as "Head First Supine" as such your original conversion was correct and you should revert
7aaa7e8

@dvm-shlee
Copy link
Member

@gdevenyi This is reverted, Thank you for letting me know! I will close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants