Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Email Services to remove implementations args from method signatures #221

Closed
elbertbautista opened this issue Jul 26, 2013 · 1 comment

Comments

@elbertbautista
Copy link
Member

Many of the Services regarding email have method signatures that require HashMap to be passed in. Refactor to pass in Map<String, Object> and make the implementation classes more robust by throwing a descriptive exception if the passed in parameter cannot be cast to the desired type.

Example:

public interface EmailService {

    public boolean sendTemplateEmail(String emailAddress, EmailInfo emailInfo,  HashMap<String,Object> props);

    public boolean sendTemplateEmail(EmailTarget emailTarget, EmailInfo emailInfo, HashMap<String,Object> props);

    public boolean sendBasicEmail(EmailInfo emailInfo, EmailTarget emailTarget, HashMap<String,Object> props);

}
elbertbautista added a commit that referenced this issue Jul 26, 2013
… method signatures; adding encoding to Emailinfo
@phillipuniverse
Copy link
Contributor

Looks like this was fixed in @elbertbautista's commit, closing.

phillipuniverse pushed a commit that referenced this issue Jul 18, 2017
Added null check in AdminSectionCustomCriteriaService
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants