Feature/django polymorphic support #29
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This logic should go in the It also belongs in the guesser, because it is assuming a naming-convention that you used, which may not always be used. |
|
Hey @Brobin , Sorry for letting you wait for a response, should I update the pull request with the logic in NameGuesser or would your prefer it to be as it is? Any other changes you would prefer to see? |
|
Hello @Brobin, Just pinging you to see what I can further do to improve this pull request! |
|
Yeah, I'd still like that logic to go on the guesser. It doesn't belong in the seeder. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for Django Polymorphic (https://github.com/chrisglass/django_polymorphic).