Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make compatible with auto_now(_add) #34

Merged
merged 2 commits into from
Mar 31, 2016
Merged

Make compatible with auto_now(_add) #34

merged 2 commits into from
Mar 31, 2016

Conversation

jgadelange
Copy link
Contributor

Fixes #33

Also some minor style stuff

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 92.544% when pulling 00a00c9 on jgadelange:master into 4617c11 on Brobin:master.

@Brobin
Copy link
Owner

Brobin commented Mar 21, 2016

Thanks Jeffrey! I'm on vacation right now but will look at this more
carefully when I get back.

On Sun, Mar 20, 2016, 7:11 AM Coveralls notifications@github.com wrote:

[image: Coverage Status] https://coveralls.io/builds/5480756

Coverage decreased (-0.4%) to 92.544% when pulling 00a00c9
00a00c9
on jgadelange:master into 4617c11
4617c11
on Brobin:master.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#34 (comment)

@Brobin
Copy link
Owner

Brobin commented Mar 31, 2016

Looks great! Could you perhaps add a test with an auto_now or auto_now_add field to validate that it works?

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 93.249% when pulling 8896bb3 on jgadelange:master into 4617c11 on Brobin:master.

Brobin
Brobin reviewed Mar 31, 2016
View reviewed changes
django_seed/tests.py
seeder.execute()

games = Game.objects.all()
self.assertTrue(any(game.created_at == date for game in games))
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't any by all? Otherwise, looks good.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. DOH!
Fixed it

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 92.616% when pulling e7c42f4 on jgadelange:master into 4617c11 on Brobin:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 93.249% when pulling 0304a1d on jgadelange:master into 4617c11 on Brobin:master.

@Brobin
Copy link
Owner

Brobin commented Mar 31, 2016

Merging! I'll get this pushed up in the next release

@Brobin Brobin merged commit 8457074 into Brobin:master Mar 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jgadelange @coveralls @Brobin