Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

seed_instance hotfix #66

Merged
merged 1 commit into from
Feb 4, 2020
Merged

seed_instance hotfix #66

merged 1 commit into from
Feb 4, 2020

Conversation

serranoarevalo
Copy link
Contributor

@serranoarevalo serranoarevalo commented Dec 28, 2019

Solves #65

Solves "Calling `.seed()` on instances is deprecated. Brobin#65  Brobin#65
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.07%) to 98.562% when pulling 9852b2d on serranoarevalo:patch-1 into d2be699 on Brobin:master.

@serranoarevalo
Copy link
Contributor Author

Hoping to get this one merged soon, currently django-seed is broken.

@hgarcia101685
Copy link

Any word on when this might be merged?
I suppose we could pull the hotfix branch and build off of that branch in the interim?

@zodman
Copy link

zodman commented Jan 7, 2020

not no body will merge ?

@hop-along-polly
Copy link

You can add Faker==2.0.5 in your project's requirements.txt to force the Faker version before the deprecation error was added. This should still get merged, but until then it's not a terrible workaround.

This only works because django-seed doesn't specify a version for Faker, so your projects required version will take precedence.

Here is the Faker commit where the Deprecation warning was added. joke2k/faker@5257c8f#diff-7305ecb8d2913b8789f3cb6a9a307c7a

@zodman
Copy link

zodman commented Jan 14, 2020

somone merge!

@peanudge
Copy link

peanudge commented Feb 4, 2020

Please Merge. My Django-Seed Broken.

@Brobin Brobin merged commit 944ad0b into Brobin:master Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants