Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added: custom seeders. #72

Merged
merged 3 commits into from Oct 22, 2020
Merged

Added: custom seeders. #72

merged 3 commits into from Oct 22, 2020

Conversation

im-n1
Copy link
Contributor

@im-n1 im-n1 commented Jun 17, 2020

I ran into a case where you might have special fields which require special values - the values are heavily validated. In this case it's nearly impossible to write guessers for such fields so I came up with an universal solution - custom seeders.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.9%) to 97.697% when pulling 2da47e3 on im-n1:custom-seeders into 27deaa2 on Brobin:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.9%) to 97.697% when pulling 2da47e3 on im-n1:custom-seeders into 27deaa2 on Brobin:master.

@AngelOnFira AngelOnFira self-requested a review July 23, 2020 17:28
@AngelOnFira
Copy link
Collaborator

I think this should be ok to add, I'll think on it today. I always imagined that if you want more than basic one-off seeding, that you'd write a script to handle it. I suppose this does have use cases though.

@AngelOnFira AngelOnFira merged commit 6cb191c into Brobin:master Oct 22, 2020
@im-n1
Copy link
Contributor Author

im-n1 commented Oct 23, 2020

FYI: Python 3.5 is dead already.

@AngelOnFira
Copy link
Collaborator

@im-n1 True, but it's not the worst to support it. I stand by not doing 2.7, there is probably a lot of breaking stuff. But 3.5 just hit EOL last month, and we're not compromising too much I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants