Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiple add entity during single execute #74

Conversation

AngelOnFira
Copy link
Collaborator

This fixes #71. It changes how some of the backend for orders works, specifically it treats orders as items that should only be done once and then removed from the orders queue. This might have adverse effects if someone runs:

seeder.execute()
seeder.execute()
seeder.execute()

However, I would argue that this is not a good way to make use of this library. I'd appreciate feedback if there are any issues with this 馃槂

The tests I wrote display behaviour that would have failed without the fixes.

@AngelOnFira AngelOnFira force-pushed the fix-multiple-add-entity-during-single-execute branch from 542edd4 to 4dd4402 Compare July 18, 2020 19:18
@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 98.656% when pulling 4dd4402 on AngelOnFira:fix-multiple-add-entity-during-single-execute into 27deaa2 on Brobin:master.

@coveralls
Copy link

coveralls commented Jul 18, 2020

Coverage Status

Coverage increased (+0.03%) to 98.656% when pulling 4dd4402 on AngelOnFira:fix-multiple-add-entity-during-single-execute into 27deaa2 on Brobin:master.

@Brobin
Copy link
Owner

Brobin commented Jul 22, 2020

This is great! Never even thought about this case. Thanks for the fix, and the test perfectly describes it

@Brobin Brobin merged commit 1818671 into Brobin:master Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add_entity and execute actions returns numbers elements multiplied by 2.
3 participants