Refactor sign display and logger update in ChestShop

Reorganized the flow of data in ChestShopSign class by separating sign display update and logging process. The method `updateSignDisplay` has been introduced to handle sign data updates, improving the modularity of the code and increasing readability. The logger now only logs when necessary, reducing the frequency of logger calls.

src/main/java/com/Acrobot/ChestShop/Signs/ChestShopSign.java

@@ -108,16 +108,7 @@ private static void updateLegacyChestShop(Sign sign) {
 
         ChestShopMetaData chestShopMetaData = new ChestShopMetaData(ownerUUID, quantity, sellPrice, buyPrice, itemStack);
 
-        UUID owner = chestShopMetaData.getOwner();
-        String fullOwnerName = NameManager.getFullNameFor(owner);
-
-        sign.setLine(0, fullOwnerName);
-        sign.setLine(3, ItemChecker.getSignItemName(itemStack));
-
         saveChestShopMetaData(sign, chestShopMetaData);
-
-        ChestShop.getPlugin().getLogger().log(Level.INFO,
-                "Converted legacy Chestshop of %s (%s) at %d %d %d".formatted(owner, fullOwnerName, sign.getX(), sign.getY(), sign.getZ()));
     }
 
     private static boolean isLegacyChestShop(Sign sign) {
@@ -143,9 +134,22 @@ public static boolean isChestShop(Sign sign) {
             return true;
         }
 
+        updateSignDisplay(sign);
+
         return sign.getPersistentDataContainer().has(METADATA_NAMESPACED_KEY, PersistentDataType.STRING);
     }
 
+    private static void updateSignDisplay(Sign sign) {
+        ChestShopMetaData chestShopMetaData = getChestShopMetaData(sign);
+
+        UUID owner = chestShopMetaData.getOwner();
+        String fullOwnerName = NameManager.getFullNameFor(owner);
+
+        sign.setLine(0, fullOwnerName);
+        sign.setLine(3, ItemChecker.getSignItemName(chestShopMetaData.getItemStack()));
+        sign.update();
+    }
+
     public static ChestShopMetaData getChestShopMetaData(Sign sign) {
 
         try {