Refactor sign checking method in ChestShop plugin

Replaced the isLegacyValid method with isChestShop in various classes for more accurate sign validation in the ChestShop plugin. This enhances the clarity of the code, allowing for easier understanding and debugging in the future.
Brokkonaut · Dec 31, 2023 · a2c24b6 · a2c24b6
1 parent fe6e05e
commit a2c24b6
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/src/main/java/com/Acrobot/ChestShop/Listeners/Block/BlockPlace.java b/src/main/java/com/Acrobot/ChestShop/Listeners/Block/BlockPlace.java
@@ -53,7 +53,7 @@ public static void onChestPlace(BlockPlaceEvent event) {
     public static void onPlaceAgainstSign(BlockPlaceEvent event) {
         Block against = event.getBlockAgainst();
 
-        if (!ChestShopSign.isLegacyValid(against)) {
+        if (!ChestShopSign.isChestShop(against)) {
             return;
         }
 

diff --git a/src/main/java/com/Acrobot/ChestShop/Listeners/Block/Break/SignBreak.java b/src/main/java/com/Acrobot/ChestShop/Listeners/Block/Break/SignBreak.java
@@ -52,7 +52,7 @@ public static void onSign(BlockPhysicsEvent event) {
         Sign sign = (Sign) block.getState();
         Block attachedBlock = BlockUtil.getAttachedBlock(sign);
 
-        if (attachedBlock.getType() == Material.AIR && ChestShopSign.isLegacyValid(sign)) {
+        if (attachedBlock.getType() == Material.AIR && ChestShopSign.isChestShop(sign)) {
             if (!block.hasMetadata(METADATA_NAME)) {
                 return;
             }
@@ -70,7 +70,7 @@ public static void onSignBreak(BlockBreakEvent event) {
 
     @EventHandler(ignoreCancelled = true, priority = EventPriority.MONITOR)
     public static void onBrokenSign(BlockBreakEvent event) {
-        if (ChestShopSign.isLegacyValid(event.getBlock())) {
+        if (ChestShopSign.isChestShop(event.getBlock())) {
             sendShopDestroyedEvent((Sign) event.getBlock().getState(), event.getPlayer());
         }
     }

diff --git a/src/main/java/com/Acrobot/ChestShop/Listeners/Block/SignCreate.java b/src/main/java/com/Acrobot/ChestShop/Listeners/Block/SignCreate.java
@@ -25,7 +25,7 @@ public class SignCreate implements Listener {
     public static void onSignChange(SignChangeEvent event) {
         Block signBlock = event.getBlock();
         if (event.getSide() == Side.BACK) {
-            if (ChestShopSign.isLegacyValid(signBlock)) {
+            if (ChestShopSign.isChestShop(signBlock)) {
                 event.setCancelled(true);
             }
             return;