Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SysIdRoutine implementation for characterizing a swerve drive #160

Merged
merged 3 commits into from Jan 30, 2024

Conversation

5010TigerDynasty
Copy link
Contributor

This is my first best pass at this. No guarantees that it gets perfect values, just that it will generate logs to use.

Copy link
Contributor

@thenetworkgrinch thenetworkgrinch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks amazing so far just needs javadocs.

src/main/java/swervelib/SwerveDriveTest.java Show resolved Hide resolved
src/main/java/swervelib/SwerveDriveTest.java Show resolved Hide resolved
src/main/java/swervelib/SwerveDriveTest.java Show resolved Hide resolved
src/main/java/swervelib/SwerveDriveTest.java Show resolved Hide resolved
src/main/java/swervelib/SwerveDriveTest.java Show resolved Hide resolved
src/main/java/swervelib/SwerveDriveTest.java Show resolved Hide resolved
src/main/java/swervelib/SwerveDriveTest.java Outdated Show resolved Hide resolved
src/main/java/swervelib/SwerveDriveTest.java Show resolved Hide resolved
Copy link
Contributor

@thenetworkgrinch thenetworkgrinch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost, the loggers need javadocs.

@thenetworkgrinch thenetworkgrinch merged commit 114e816 into BroncBotz3481:dev Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants