-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(image): support Transformer from SVG #44
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
c9d62fe
to
142ecd5
Compare
142ecd5
to
ffaeb61
Compare
ffaeb61
to
1a28612
Compare
1a28612
to
ec156eb
Compare
background: Option<String>, | ||
) -> Result<Transformer> { | ||
let mut fontdb = Database::new(); | ||
fontdb.load_system_fonts(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we consider providing an API to load only specified fonts in the future? This would improve the speed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good Idea! Welcome to PR~ 🙏
|
||
let mut size = tree.size.to_screen_size(); | ||
let min_svg_size = 1000; | ||
while size.width() < min_svg_size || size.height() < min_svg_size { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason for this minimum size requirement? I'd prefer if this rendered my SVG at the input resolution
Resolve #43