feat(image): support Transformer from SVG#44
Merged
Brooooooklyn merged 1 commit intomainfrom Feb 27, 2023
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
liby
force-pushed
the
feature/support-svg
branch
from
c9d62fe to
142ecd5
Compare
liby
force-pushed
the
feature/support-svg
branch
from
142ecd5 to
ffaeb61
Compare
liby
force-pushed
the
feature/support-svg
branch
from
ffaeb61 to
1a28612
Compare
liby
force-pushed
the
feature/support-svg
branch
from
1a28612 to
ec156eb
Compare
yisibl
reviewed
Feb 28, 2023
| background: Option<String>, | ||
| ) -> Result<Transformer> { | ||
| let mut fontdb = Database::new(); | ||
| fontdb.load_system_fonts(); |
There was a problem hiding this comment.
Can we consider providing an API to load only specified fonts in the future? This would improve the speed.
Collaborator
Author
There was a problem hiding this comment.
Good Idea! Welcome to PR~ 🙏
martinmiglio
reviewed
Jun 3, 2024
|
|
||
| let mut size = tree.size.to_screen_size(); | ||
| let min_svg_size = 1000; | ||
| while size.width() < min_svg_size || size.height() < min_svg_size { |
There was a problem hiding this comment.
Is there a reason for this minimum size requirement? I'd prefer if this rendered my SVG at the input resolution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve #43