fix: negative letter spacing (#813)

Brooooooklyn · Apr 17, 2024 · 11ab7e2 · 11ab7e2
1 parent ec40123
commit 11ab7e2
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 1 deletion.
diff --git a/__test__/snapshots/negative-letter-spacing.png b/__test__/snapshots/negative-letter-spacing.png
diff --git a/__test__/text.spec.ts b/__test__/text.spec.ts
@@ -119,6 +119,19 @@ test('letter-spacing', async (t) => {
   await snapshotImage(t, { canvas, ctx })
 })
 
+test('negative-letter-spacing', async (t) => {
+  const canvas = createCanvas(800, 800)
+  const ctx = canvas.getContext('2d')!
+  ctx.font = '30px Iosevka Slab'
+
+  // Default letter spacing
+  ctx.fillText(`Hello world (default: ${ctx.letterSpacing})`, 10, 40)
+
+  ctx.letterSpacing = '-5px'
+  ctx.fillText(`Hello world (${ctx.letterSpacing})`, 10, 90)
+  await snapshotImage(t, { canvas, ctx })
+})
+
 test('word-spacing', async (t) => {
   const canvas = createCanvas(800, 800)
   const ctx = canvas.getContext('2d')!

diff --git a/src/ctx.rs b/src/ctx.rs
@@ -35,7 +35,7 @@ use crate::{
 };
 
 static CSS_SIZE_REGEXP: Lazy<Regex> =
-  Lazy::new(|| Regex::new(r#"([\d\.]+)(%|px|pt|pc|in|cm|mm|%|em|ex|ch|rem|q)?\s*"#).unwrap());
+  Lazy::new(|| Regex::new(r#"(-?[\d\.]+)(%|px|pt|pc|in|cm|mm|%|em|ex|ch|rem|q)?\s*"#).unwrap());
 
 impl From<SkError> for Error {
   fn from(err: SkError) -> Error {