fix: memory leak while encoding png from Canvas (#791)

Brooooooklyn · Feb 22, 2024 · 3f17b38 · 3f17b38
1 parent a70a8d4
commit 3f17b38
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/skia-c/skia_c.cpp b/skia-c/skia_c.cpp
@@ -218,8 +218,9 @@ extern "C"
 
   void skiac_surface_png_data(skiac_surface *c_surface, skiac_sk_data *data)
   {
-    auto image = SURFACE_CAST->makeImageSnapshot();
-    auto png_data = SkPngEncoder::Encode(nullptr, image.release(), SkPngEncoder::Options());
+    auto image = SURFACE_CAST->makeImageSnapshot().release();
+    auto png_data = SkPngEncoder::Encode(nullptr, image, SkPngEncoder::Options());
+    image->unref();
     if (png_data)
     {
       data->ptr = png_data->bytes();