New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: multiple define on cached native object in jest #587

Merged

Brooooooklyn merged 1 commit into Brooooooklyn:main from nomagick:main

Jan 1, 2023

Contributor

nomagick commented Nov 21, 2022

In jest testing environments:

Modules are require/import multiple times and not cached.
However, looks like native objects ARE being cached.
This caused Object.defineProperty in the require script to run multiple times and throws on the same native object(namely GlobalFonts).

Contributor Author

nomagick commented Nov 21, 2022

FYI this is blocking my adoption of this module.


          fix: multiple define on cached native object in jest

88f5ee9

Brooooooklyn force-pushed the main branch from 56530d2 to 88f5ee9 Compare

January 1, 2023 12:21

Brooooooklyn merged commit 110d92f into Brooooooklyn:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment