Outer dev #292
Merged
Outer dev #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- pick and pass a port along to the docviewer script - automatically setup the secrets/key.js file on install - modify the get_download_view_url.sh script to utilize the domain name and port to make requests to
…default port Need to hit the other items in the todo list
- pick and pass port - get view url script utilizes correct name and port
…er-dev DONE: - pick and pass a port along to the docviewer script - automatically setup the secrets/key.js file on install - modify the get_download_view_url.sh script to utilize the domain name and port to make requests to - fix heredoc computation of domain name in sourced config script - set up secrets/key.js or make it an env variable (better idea) for the API_KEY for the doc viewer service - probably create that api key to exist in the config script
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
CodeQL found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
|
need to fix these codeQL critical alerts on chai before we merge this in |
There was a problem hiding this comment.
CodeQL found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
| res.redirect(viewUrl); | ||
| } else if ( sendURL ) { | ||
| res.type('text/plain'); | ||
| res.end(viewUrl); |
Check warning
Code scanning / CodeQL
Reflected cross-site scripting Medium
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completed integration of new doc viewier (chai) with the rest of the system.
Basic integration complete. Consisting of:
Some bugs exist and are tracked at: https://github.com/dosyago/chai