Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolved issue #338 #343

Merged
merged 2 commits into from
Sep 26, 2023
Merged

resolved issue #338 #343

merged 2 commits into from
Sep 26, 2023

Conversation

sushil026
Copy link
Contributor

@sushil026 sushil026 commented Sep 25, 2023

Resolved issue #338
Changed button hover property by setting new color property.
save

closes #338
closes #336

Signed-off-by: sushil026 <68173862+sushil026@users.noreply.github.com>
@CLAassistant
Copy link

CLAassistant commented Sep 25, 2023

CLA assistant check
All committers have signed the CLA.

@o0101
Copy link
Collaborator

o0101 commented Sep 25, 2023

Hey @sushil026 sorry can you sign the CLA?

Signed-off-by: sushil026 <68173862+sushil026@users.noreply.github.com>
@o0101
Copy link
Collaborator

o0101 commented Sep 25, 2023

Re: #338 (comment)

Yes @sushil026 as mentioned above and by the CLA assistant you need to sign the CLA. You can sign here It's a condition of contribution to the project! Otherwise we cannot accept your contribs! Seems as if you have concerns about signing?

@sushil026 sushil026 closed this Sep 25, 2023
@sushil026 sushil026 reopened this Sep 25, 2023
@sushil026
Copy link
Contributor Author

sushil026 commented Sep 25, 2023

no, there are no concerns regarding signing it
@00000o1 please check the CLA signed
I've received this prompt "You have agreed to the CLA for BrowserBox/BrowserBox" on the CLA Assistant page

@o0101
Copy link
Collaborator

o0101 commented Sep 26, 2023

@sushil026 OK! Thanks mate ☺️ . Let me take some time to review your changes and if OK we'll get you all merged in! Thank you again :)

Copy link
Collaborator

@o0101 o0101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💜

@o0101 o0101 merged commit a63dc37 into BrowserBox:boss Sep 26, 2023
2 of 3 checks passed
@sushil026
Copy link
Contributor Author

@00000o1 the changes are not visible on the site, can u pls tell why is this so?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants