Fixes 2 more tasks in #464 - regarding viewport correct sizing on client #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent changes The new fixes attempt to fix an effect of over optimization. We'd previously been trying to limit the amount of time we reset the viewport. That had caused a bug where we missed when a non-active tab was in an old larger size prior to a smaller client connect, but as we only had a single 'per browser' viewport memory, and we'd already update the viewport of the active tab, when switching back to this larger tab, after the browser viewport had already been updated, our test showed there was no change to be made. This is because we didn't have a per target viewport memory. Now we do. This fixes the bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent updates address an issue caused by excessive optimization in our approach. Previously, we aimed to minimize how often we reset the viewport. However, this strategy led to a bug affecting non-active tabs. Here's the scenario:
The root cause? We only had a single, browser-wide memory for viewport size, rather than individual memory for each target (tab).
The solution? We've now implemented a per-target (per-tab) viewport memory system. This enhancement enables the correct adjustment of viewport sizes for each tab individually, effectively resolving the bug.