Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove node-uuid deprecation warning #1403

Merged
merged 1 commit into from
Jul 4, 2017
Merged

Remove node-uuid deprecation warning #1403

merged 1 commit into from
Jul 4, 2017

Conversation

swashcap
Copy link
Contributor

Problem

node-uuid, which browser-sync indirectly depends on, is deprecated. npm gives this warning during installations:

$ npm install
# ...
npm WARN deprecated node-uuid@1.4.8: Use uuid module instead
# ...

Solution

browser-sync’s dependency localtunnel depends on node-uuid:

$ npm ls node-uuid
# ...
├─┬ browser-sync@2.18.12
│ └─┬ localtunnel@1.8.2
│   └─┬ request@2.78.0
│     └── node-uuid@1.4.8  deduped
# ...

Fortunately, localtunnel@1.8.3 upgraded to uuid. Upgrading localtunnel in browser-sync fixes the problem.

Testing

Running npm test yields:

  464 passing (9s)
  10 pending

🎉

@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.402% when pulling 4ff95ec on swashcap:upgrade/localtunnel into 8d1e298 on BrowserSync:master.

@shakyShane shakyShane merged commit 470ab02 into BrowserSync:master Jul 4, 2017
@swashcap swashcap deleted the upgrade/localtunnel branch July 4, 2017 18:13
@swashcap
Copy link
Contributor Author

👍 Thanks for the merge. Could you push a patch version bump so this is available via npm?

@shakyShane
Copy link
Contributor

done, browser-sync@2.18.13 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants