Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security: Update vulnerable dependencies #1659

Closed
wants to merge 3 commits into from

Conversation

rouanw
Copy link

@rouanw rouanw commented Feb 18, 2019

This Pull Request addresses some vulnerabilities reported by npm audit:

@shakyShane do you mind taking a look please?

@rouanw
Copy link
Author

rouanw commented Feb 18, 2019

I see the AppVeryor build for node 4 failed - looks like there was a checksum mismatch while installing rxjs.

@rouanw
Copy link
Author

rouanw commented Feb 20, 2019

@shakyShane have you had a chance to take a look?

I haven't used AppVeyor, but I suspect a contributor to the library will be able to re-run the failed job. (I did some reading and AppVeyor is apparently prone to network and connectivity glitches, which may explain the failed install.)

@j-oliveras
Copy link

@rouanw You can try closing and re-opening to retrigger CI.

@saidkholov
Copy link

any updates on this?

@simonmaass
Copy link

any news when this will be fixed?

@Clement-TS
Copy link

up, any news on that?

@dennisreimann
Copy link

@shakyShane Can you please have a look and retrigger the AppVeyor build? It'd be great to have a new release with these updates. Please let me know if there is something we could help with, I guess people are eagerly waiting for a new version which incorporates the vulnerability fixes. Thanks!

@dennisreimann
Copy link

There hasn't been any commit activity for the last half year and not receiving an answer here makes me wonder, whether or not this repo is still maintained. As I said I'd be willing to help out, since I'm relying on BrowserSync in several of my projects and I'd rather not see this project fade away.

@shakyShane
Copy link
Contributor

I'm looking into all security related PRs now :)

shakyShane added a commit that referenced this pull request Apr 22, 2019
@shakyShane
Copy link
Contributor

fixed in 2.26.4, thanks for your contribution :)

@shakyShane shakyShane closed this Apr 22, 2019
@Berkmann18
Copy link

@shakyShane Is there a reason why you don't merge people's contribution and instead of copying what they did?

@shakyShane
Copy link
Contributor

@Berkmann18 just in this case, there were 4 different open PRs, all with slightly different fixes.

This happened purely because I was absent for so long, something I regret and am sorry for. Once I did get around to this, with only of hours to spare I made the decision to perform all updates in 1 go, rather than attempt to cherry pick bits and pieces spread across 4 PRs.

I value PRs greatly, and have accepted/merged many in the past - but for this one, just because of time restraints, I decided against it.

Hope that clears it up, and doesn't discourage further contributions in the future

@Berkmann18
Copy link

@shakyShane Thanks for the clarification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet