Trust binaries signed for Waterfox (about:third-party) #3269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes about:third-party not trusting any of Waterfox's dll files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix
about:third-partynot trusting any of Waterfox's DLL files.This means the user can no longer "brick" their browser as shown in the images below, it also might improve performance to some extent since now the browser won't do any checking against core browser DLLs treating them like they are unknown.
Also this may help or solve issue #3187 although this is just a guess.
core browser DLL being treated as unknown/third-party:
the result of blocking xul.dll and then attempting to launch Waterfox (the only way to get Waterfox working again is to go to
%AppData%\WaterfoxLimited\Waterfox\In Windows and delete everything in the "disabled" folder.):