Rule dependency complete resolution #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for Property Rules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, rules were modifying the graph in place.
This was causing a LOT of issues.
Now, rules adds quads to another graph, and resolve the whole rule dependency tree.
Code is cleaner and more simple to understand because we don't have to inspect the content of any data RDF-star quad anymore.
This PR also includes some test folder reorganization.
Some unit tests have been modified: the tests that were about transforming an edge while also transforming the already transformed properties have been removed because they are not relevant anymore. But this modification should be transparent for an end user, as they should never manipulate any PREC-0 graph, and if they manipulate any, they should never manipulate the temporary graphs producing during PREC-C.