Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KnownTileSources: use scaled variants of BKG maps #162

Merged
merged 1 commit into from
Jan 21, 2022
Merged

KnownTileSources: use scaled variants of BKG maps #162

merged 1 commit into from
Jan 21, 2022

Conversation

janusw
Copy link
Member

@janusw janusw commented Jan 4, 2022

  • in the default variants, the higher zoom levels (>15) outside of Germany are missing
  • the scaled variants show a scaled-up version of the highest available zoom level
    for all levels above it
  • also, the current year is now shown in the attribution (as demanded by BKG)

@janusw
KnownTileSources: use scaled variants of BKG maps
0324ba5 
* in the default variants, the higher zoom levels (>15) outside of Germany are missing
* the scaled variants show a scaled-up version of the highest available zoom level
  for all levels above it
* also, the current year is now shown in the attribution (as demanded by BKG)
@janusw
Copy link
Member Author

janusw commented Jan 4, 2022

This is sort of a follow-up to #129.

@janusw
Copy link
Member Author

janusw commented Jan 4, 2022

Btw, I just noticed that the GitHub Actions build is only done for pushes to the repo, but apparently not for PRs across forks. Maybe the GHA config should be adjusted to fix this?

@pauldendulk
Copy link
Contributor

Btw, I just noticed that the GitHub Actions build is only done for pushes to the repo, but apparently not for PRs across forks. Maybe the GHA config should be adjusted to fix this?

Yes, that would make sense. Improvements are welcome. I only added it to make a start with GHA, did not try to achieve anything more yet.

@pauldendulk pauldendulk merged commit af3daf2 into BruTile:master Jan 21, 2022
@janusw janusw deleted the bkg_scaled branch January 22, 2022 07:53
@janusw
Copy link
Member Author

janusw commented Jan 22, 2022

Btw, I just noticed that the GitHub Actions build is only done for pushes to the repo, but apparently not for PRs across forks. Maybe the GHA config should be adjusted to fix this?

Yes, that would make sense. Improvements are welcome.

See #166. Also: Thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@janusw @pauldendulk