Made GetTile Async for fixing Wasm #169
Conversation
inforithmics
changed the title
|
To fix The appveyor Build the appveyor.yml needs to be included in the repository so I could fix it. |
|
Changes:
|
inforithmics
force-pushed
the
WasmCompatibility
branch
from
b08eacc
to
4eaea63
Compare
| @@ -27,6 +27,7 @@ | |||
| <s:Boolean x:Key="/Default/Environment/InjectedLayers/FileInjectedLayer/=712F7012C17E2549846B478E6E138577/@KeyIndexDefined">True</s:Boolean> | |||
| <s:Boolean x:Key="/Default/Environment/InjectedLayers/InjectedLayerCustomization/=File712F7012C17E2549846B478E6E138577/@KeyIndexDefined">True</s:Boolean> | |||
| <s:Double x:Key="/Default/Environment/InjectedLayers/InjectedLayerCustomization/=File712F7012C17E2549846B478E6E138577/RelativePriority/@EntryValue">2</s:Double> | |||
| <s:Boolean x:Key="/Default/Environment/SettingsMigration/IsMigratorApplied/=JetBrains_002EdotCover_002EIde_002ECore_002EFilterManagement_002EModel_002ESolutionFilterSettingsManagerMigrateSettings/@EntryIndexedValue">True</s:Boolean> | |||
There was a problem hiding this comment.
I did not know you used ReSharper?
NuGet.config
Outdated
| @@ -6,8 +6,8 @@ | |||
| <packageSources> | |||
| <clear /> | |||
| <add key="nuget.org" value="https://api.nuget.org/v3/index.json" /> | |||
| <add key="dotnet-core" value="https://dotnetfeed.blob.core.windows.net/dotnet-core/index.json" /> | |||
| <!--<add key="dotnet-core" value="https://dotnetfeed.blob.core.windows.net/dotnet-core/index.json" /> | |||
There was a problem hiding this comment.
Did this cause a problem for you? Should it be removed completely?
| @@ -0,0 +1,192 @@ | |||
| using System; | |||
There was a problem hiding this comment.
This is so much code. This needs to be maintained. Could the Mapsui package itself be used to present these samples? (needs to be released first).
There was a problem hiding this comment.
Yes I think this would be better, and making it a simpler example. I will slim down this pull request, for that.
There was a problem hiding this comment.
Also not sure if we need a sample. For your development it was good to see wasm now actually worked, but now it does do we still need it? Mapsui already has a dependency on Uno, so you could show how it works in there. Is there another benefit of the sample that could not be shown in the other samples?
There was a problem hiding this comment.
Then I remove the Uno Sample, because it works better in Mapsui (probably not tested yet)
inforithmics
changed the title
inforithmics
changed the title
| @@ -18,12 +17,11 @@ public class Fetcher<T> | |||
| private double _unitsPerPixel; | |||
There was a problem hiding this comment.
I was thinking about the BlockingCollection for fetching (mentioned in the Mapsui 'about events' developers post). Perhaps this sample is a good place to try that out.
No description provided.