Updated NUnit and replaced WebRequest with HttpClient #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I had to change some Methods to Async, I made the non Async methods Obsolete and call the Async Methods with .Result. So this stays compatible and no Major Version is needed. Had to upgrade NUnit to for AsyncTestDelegate |
… finishing on Main Thread)
pauldendulk
changed the title
pauldendulk
approved these changes
Jul 11, 2023
| @@ -20,6 +21,7 @@ public static class HttpWebRequestExtensions | |||
| /// parameter was set, and no response was received within the specified | |||
| /// time.</exception> | |||
| /// <see href="http://www.hardcodet.net/2010/02/blocking-httpwebrequest-getresponse-for-silverlight"/> | |||
| [Obsolete("Use HttpClient")] | |||
There was a problem hiding this comment.
This is a nice way to help users upgrade to a newer version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes this Mapsui/Mapsui#2107 (for wmts and tms)