Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WmtsParser.cs: adding a test if a layer has no Style #212

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

franky235
Copy link
Contributor

The idea is to avoid NullReferenceException that cancel parsing Continue parsing instead

The idea is to avoid NullReferenceException that cancel parsing
Continue parsing instead
@pauldendulk
Copy link
Contributor

Thanks. In what kind of service did you run into this null value? It still valid according to the spec? Even if not valid it is good to check for it, just curious.

@franky235
Copy link
Contributor Author

https://wxs.ign.fr/essentiels/geoportail/wmts?SERVICE=WMTS&REQUEST=getcapabilities
Good question, I am curious too
I checked and the layer ADMIN_EXPRESS is not valid according to wmts1.0 xsd schema ! (Style is missing...)
I will contact IGN to ask them to fix it but it is a large public company, not very responsive
In the mean time I need to move forward

BTW, thanks for your quick reply !

@franky235
Copy link
Contributor Author

FYI QGIS can parse IGN WMTS getcapabilities even if not fully compliant to the spec
I think it would be good if BruTile can do it also, after all it is a minor change don't you think ?

Copy link
Contributor

@pauldendulk pauldendulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BruTile should function properly even if the service does not comply to the specification. Good fix.

@pauldendulk pauldendulk merged commit 3e9ff85 into BruTile:master Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants