Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FisheyeToPinholeSampler #29

Open
LamHoCN opened this issue Sep 7, 2023 · 2 comments
Open

FisheyeToPinholeSampler #29

LamHoCN opened this issue Sep 7, 2023 · 2 comments

Comments

@LamHoCN
Copy link

LamHoCN commented Sep 7, 2023

hey brummi ~
I have some question with FisheyeToPinhole.
I tried to visualize the fisheye img after this sample function.
I used the kitti360 data_fisheye_calibration data and calibration results which you support, and then I used the resamle function, after resampling it cut a lot, a lot of information is missing, I was wondering if I could focus on the fisheye camera information, Maybe I don't need such resample ? Looking forward to your reply, really appreciate.
0000001216
a

@Brummi
Copy link
Owner

Brummi commented Sep 12, 2023

Hi!
I am glad that you like our method!

Yes, the Crop is quite narrow, but this way it has exactly the same camera intrinsics as the other cameras.

In theory, you could also directly cast and project rays from and to the fisheye camera. However, these operations involve more steps and can't be vectorized as easily as with pinhole camera. Having two different camera models would make the pipeline quite a bit more complex. But it is definitely possible and then you also wouldnt need the resampling.

You would have to adapt the ray samplers and the projection and the color sampling.

Let me know if you make it work. :D

Best,
Felix

@LamHoCN
Copy link
Author

LamHoCN commented Sep 15, 2023

Hi~ Felix!
Thanks for your reply. I will try it in different camera models(opencv fisheye or fisheye rectifiction ...)
I will let you know, If it work ~ :D
Best,
merlin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants