Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MODX 3.0 Support #355

Closed
wants to merge 1 commit into from
Closed

MODX 3.0 Support #355

wants to merge 1 commit into from

Conversation

crystaldaking
Copy link

MODX 3.0 Support

@@ -1,4 +1,4 @@
--------------------
ы--------------------
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whats this?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorryy, its my macbook keyboard

@Bruno17
Copy link
Owner

Bruno17 commented Jan 18, 2020

Thank you very much, @crystaldaking, for that PR
I think, this should go into a new branch, 'modx3' or something
This will not be backwards - compatible to revolution 2.x, right?
Not sure, how to handle that.

I've installed your zip - file, which you posted on slack on a new MODX alpha 1
What I've found so far at a very quick look:

  • seems to install fine so far
  • after Installation MODX Package Manager shows Not Installed
  • I can create and use simple MIGX - TVs fine
  • MIGX config-CMP shows Requested processor not found in its grid

@crystaldaking
Copy link
Author

crystaldaking commented Jan 20, 2020

I think, this should go into a new branch, 'modx3' or something
This will not be backwards - compatible to revolution 2.x, right?
Not sure, how to handle that.

No way :(
Yep, we need to create 3.x branch

after Installation MODX Package Manager shows Not Installed

Hmm

MIGX config-CMP shows Requested processor not found in its grid

I will add it to my backlog

@Bruno17 Bruno17 changed the base branch from master to for-3 March 6, 2021 16:49
@Bruno17 Bruno17 deleted the branch Bruno17:for-3 December 28, 2021 07:20
@Bruno17 Bruno17 closed this Dec 28, 2021
@Ibochkarev
Copy link

@Bruno17 Good afternoon!

Tell me, please, can the community expect MODX 3 support?

@Bruno17
Copy link
Owner

Bruno17 commented Dec 28, 2021

I'm currently trying to work on it. But this PR has to much changes at once and is difficult to test.
I will try to implement and test changes of that PR in small parts. I think, there has more to be done, than just this PR to get everthing working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants