Hide recharge number. #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having worked on quite a few class configs this option makes a mess of other options. There are a few bars which are tracking a stacking buff and have a recharge underneath them. Survival Hunter's Mongoose Bite is a singular example, other configs I've got tracking a buff while having the recharge of a different ability underneath the bar. The display gets VERY confusing if the recharge is displayed numerically as well as graphically, even for setups I'm familiar with I lose track. I'm not sure how it works out which number it displays either, it didn't seem consistent. I remember this was a requested feature, it seemed a reasonable request but in practice it doesn't work. At the time of the request it wasn't implemented yet, that was just based off the video feedback.
|
At the moment it's a last-write-wins approach, so if there's multiple things setting the stack number it'll be whichever happened most recently. I can definitely see this being confusing. I'll merge this in and then think of a better way to approach this so that it's less confusing! Thanks for the feedback! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having worked on quite a few class configs this option makes a mess of other options.
There are a few bars which are tracking a stacking buff and have a recharge underneath them.
Survival Hunter's Mongoose Bite is a singular example, other configs I've got tracking a buff while having the recharge of a different ability underneath the bar.
The display gets VERY confusing if the recharge is displayed numerically as well as graphically, even for setups I'm familiar with I lose track. I'm not sure how it works out which number it displays either, it didn't seem consistent.
I remember this was a requested feature, it seemed a reasonable request but in practice it doesn't work. At the time of the request it wasn't implemented yet, that was just based off the video feedback.