Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add ToggleSwitch component & Giant Arrow logic #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

CFU9
Copy link

@CFU9 CFU9 commented Dec 28, 2023

With the introduction of the Giant Arrow many clashers might want to use a combination of zaps and quakes, in conjunction with the Giant Arrow, to take down important structures of an enemy base.
This MR adds the optional functionality for calculating zapquakes in conjunction with the Giant Arrow.
This functionality is off by default.

Features

  • Level Input for queen's Giant Arrow
  • toggle-switch for enabling and disabling the use of the Giant Arrow
  • adjust zapquake calculation to include the Giant Arrow

Additional information

With the December 2023 update Clash of Clans introduced Hero Equipment.
One of the Archer Queen's Equipment pieces is the Giant Arrow.
When activated the Giant Arrow flies in a straight path across the base and damages everything along its path.
The Giant Arrow can be especially useful for removing or damaging key defenses. While the Giant Arrow does quite a lot of damage on its own many buildings will need additional zaps and/or quakes to be taken down.
https://clashofclans.fandom.com/wiki/Giant_Arrow

Comments

I don't have any prior experience with React or Tailwind so some solutions might be suboptimal.
The Toggle Switch is fine, but could be designed in a nicer way.
There might be a more intuitive / overall better solution for turning on and off the Giant Arrow functionality.

Copy link

netlify bot commented Dec 28, 2023

👷 Deploy request for zapquaker pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 6a55195

@Bryght7
Copy link
Owner

Bryght7 commented Feb 28, 2024

Hello, thank you for your MR ! It is much appreciated.

I haven't been on my computer for a couple of months due to personal reasons, but I will take time to review your contribution as soon as I can.

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants