Skip to content

Commit

Permalink
Revert "[Mono.Debugger.Soft] Properly close connections"
Browse files Browse the repository at this point in the history
This reverts commit 2da7707.

This was previously reverted because it was causing issues and it still does. It is a hack fix. We signal the connection for closing and next we send the dispose command over the network. This is obviously racy.
  • Loading branch information
BrzVlad committed Sep 26, 2019
1 parent c81b6f5 commit b9451f1
Showing 1 changed file with 4 additions and 1 deletion.
Expand Up @@ -150,8 +150,11 @@ public class VirtualMachine : Mirror
}

public void Detach () {
conn.Close ();
// Notify the application that we are detaching
conn.VM_Dispose ();
// Close the connection. No further messages can be sent
// over the connection after this point.
conn.Close ();
notify_vm_event (EventType.VMDisconnect, SuspendPolicy.None, 0, 0, null, 0);
}

Expand Down

0 comments on commit b9451f1

Please sign in to comment.