Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

documentation - edits to Sound Patterns #177

Conversation

HighHarmonics2
Copy link
Contributor

Includes:

  • full revision of 6.4 Sound Patterns section
  • tightened up the description - removing narrative elements and focus on code with short explanations
  • added some focus on the Player concept
  • added a period with a number value in the first example
  • edits to strings vs number paragraph
  • other text changes to improve clarity

@Bubobubobubobubo - please review in detail.

@Bubobubobubobubo
Copy link
Owner

Yes, it looks like an useful revision. Aside from the grammar improvements that are noticeable, I find the tone more in line with what is expected of a tutorial. This is something that could be extended, I think, to all the introductory sections at least, even if it means keeping the more informal style for the more advanced parts that require less concentration.

@Bubobubobubobubo
Copy link
Owner

I'll make sure to regenerate the documentation today in order to bring it online. Thanks for your input!

@Bubobubobubobubo Bubobubobubobubo merged commit adfe824 into Bubobubobubobubo:main Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants